Re: [Templates] Announce: Template::Plugin::Gravatar (Feedback, code review, comments)

[Darren Chamberlain]

* apv <[EMAIL PROTECTED]> [2006/03/18 21:52]:
> I just put up http://search.cpan.org/dist/Template-Plugin-Gravatar/
> 
> It's my first TT plugin and I'd love anyone interested (and maybe with 
> Gravatar experience though it's not required) to take a peek.

This looks good.  The only thing I'd question (not to beat this dead
horse again) is that the sub returned from new joins the parameters
with &amp; and not &;

        my $uri = join("?",
                       $args->{base},
                       join("&amp;",
                            @pairs
                            )
                       );

The means that you need to unescape this URL for use outside of an
attribute.  I'd rather see it return a URL joined on & and be used
like:

 [% USE Gravatar %]
  <img src="[% Gravatar( email => user.email ) | html %]"
    alt="[% user.name %]" />

I like the ability to set global defaults with the GRAVATAR option to
the Context.  Slick.

(darren)

-- 
Every thought you think is contributing its share to the ultimate
result of your life.

pgpmjeKoH9DL1.pgp
Description: PGP signature