apv wrote:
On Monday, March 20, 2006, at 05:12  AM, Darren Chamberlain wrote:
Since the Gravatar plugin essentially only creates URLs, maybe it
should subclass Template::Plugin::URL, and its new method should
simply be a call to SUPER with the correct parameters.  That would
"resolve" the issue, since it would then rely on TT doing the right
thing, and respect a user-set $JOINT.


I do think the subclass idea might be the way to go. Respecting
the same $JOIN(T?) interface seems mandatory at least.

Since this plugin is specifically creating URLs for gravatar.com it would probably be best to only use a separator that gravatar.com will support, '&'. Using $JOINT will only create the possibility for breakage.

BTW, PHP has a setting, arg_separator.input, that can be set to multiple characters (so ; can be supported) but it defaults to only '&'.

-Stuart

_______________________________________________
templates mailing list
[email protected]
http://lists.template-toolkit.org/mailman/listinfo/templates

Reply via email to