On Monday, March 20, 2006, at 05:12 AM, Darren Chamberlain wrote:
Since the Gravatar plugin essentially only creates URLs, maybe it should subclass Template::Plugin::URL, and its new method should simply be a call to SUPER with the correct parameters. That would "resolve" the issue, since it would then rely on TT doing the right thing, and respect a user-set $JOINT.
Of course I forgot to reply all the other day when I said: "Yeah, I thought about that (not hard enough maybe) and cast the die the wrong the way I think. I'll switch it. Now if we could just get everyone to use semicolons instead of ampersands for query strings we could achieve world peace." The updated (with more tests and a couple fixes) version went up yesterday: http://search.cpan.org/dist/Template-Plugin-Gravatar/ I do think the subclass idea might be the way to go. Respecting the same $JOIN(T?) interface seems mandatory at least. -Ashley _______________________________________________ templates mailing list [email protected] http://lists.template-toolkit.org/mailman/listinfo/templates
