Stuart Johnston wrote:
apv wrote:
On Monday, March 20, 2006, at 05:12 AM, Darren Chamberlain wrote:
Since the Gravatar plugin essentially only creates URLs, maybe it
should subclass Template::Plugin::URL, and its new method should
simply be a call to SUPER with the correct parameters. That would
"resolve" the issue, since it would then rely on TT doing the right
thing, and respect a user-set $JOINT.
I do think the subclass idea might be the way to go. Respecting
the same $JOIN(T?) interface seems mandatory at least.
Since this plugin is specifically creating URLs for gravatar.com it
would probably be best to only use a separator that gravatar.com will
support, '&'. Using $JOINT will only create the possibility for breakage.
I don't see how this could hurt. It would require someone with coding knowledge/access to
change the default of '&'. (Why would they use something that doesn't work?) While the
'&' only behavior would seem fine, you never know what people might try to do with the
plugin. Maybe they plan on taking the URL into some other program and deconstructing it
there, and it would be easier to use ';' or '&' or some other joiner.
-- Josh
_______________________________________________
templates mailing list
[email protected]
http://lists.template-toolkit.org/mailman/listinfo/templates
