Comments from the bug report > Comment #3 From Aubrey.Li 2009-04-14 23:41:27 ------- > > I attached a patch. > > Changelog: > > 1) change g_msg_idle_state, the current string is too long, > for the alignment issue, the string "(idle power states" was removed.
How about just (idle states) ? I know it's a nit, but new users have no idea what a C-state is. > 2) in idle dtrace walk, if g_cstate_info[0].total_time < n, > means the processor has no residency in C0. This case should be considered. > Otherwise, the first time, C0 is almost the same as C3 forever. True. > 3) C-state residency average. Both the number and the time are the aggregation > of all the CPUs, so dividing g_ncpu_observed is not necessary here. I agree. > 4) frequency title need a "\n", this is necessary in the dump mode Ok. Thanks, Rafael
