> --- Comment #1 from Rafael Vanoni <rafael.vanoni at sun.com> 2009-04-14 > 21:05:40 --- My putback for > > 6828678 PowerTOP has erroneous use of memset(3C) > > had an error. One of the calls to memset remained with the incorrect > value: > > 266 (void) memset(g_event_info, 0, > 267 EVENT_NUM_MAX * sizeof (event_info_t)); > 268 (void) memset(g_cstate_info, NSTATES > 269 * sizeof (state_info_t), 0); > > But the same putback removed the code in cpu_idle.c that was manually > zeroing the g_cstate_info array item by item. > > Apologies for the mistake, I'll putback a fix first thing tomorrow. > Hi Rafael,
Manually patch modification is not a good idea, I also noticed the string g_msg_idle_state is "C-state (idle power state)" in the powertop gate while is "C-state (idle power states)" in the ONNV gate. There are also other difference. Everything you want to change should be a patch, otherwise the gate merge work will become harder. Thanks, -Aubrey
