Li, Aubrey wrote: > Eric.Saxe wrote: > >> Li, Aubrey wrote: >>> Rafael.Vanoni wrote: >>> >>> >>>> Comments from the bug report >>>> >>>> >>>>> Comment #3 From Aubrey.Li 2009-04-14 23:41:27 ------- >>>>> >>>>> I attached a patch. >>>>> >>>>> Changelog: >>>>> >>>>> 1) change g_msg_idle_state, the current string is too long, >>>>> for the alignment issue, the string "(idle power states" was >>>>> removed. >>>>> >>>> How about just (idle states) ? I know it's a nit, but new users >>>> have no idea what a C-state is. >>>> >>>> >>> I'm still suggesting C-state, :) >>> >> My 2c: I think having C-state there is ok (provided the right thing >> happens on non-x86 systems)...but having something in "()" >> after (a word >> or two) which tells users these are power states for idle CPUs makes >> sense to me. The trick is coming up with something short and >> descriptive... >> >> How about: "C-states (Idle power)"? >> >> -Eric > > "C-states (Idle power)" has no alignment issue and good to me. > > Thanks, > -Aubrey
Cool. Please push your changes for 8172, with this addition, and 8873. Both look good to me. Thanks, Rafael
