Rafael.Vanoni wrote:

> Here's the patch, let me know what you think.
>
event window is bad.

1) nlines: in the patch, nlines = maxy-13.
This is wrong, it should depend on max(ncstates, npstates).

2) begin y: in the patch, begin_y = win_pos++.
nlines(wakeup) = 1, begin_y(wakeup) = win_pos++,
then begin_y(acpi_power) = win_pos++ has no problem.
But the patch set nlines(acpi_power) = 2, so begin_y of the next
subwindow
should be begin_y(acpi_power) + 2, not just win_pos++.

Is that correct?

3) please consider to give one blank line between event window and
suggestion window.

Thanks,
-Aubrey

Reply via email to