2008/5/22 Rafael Vanoni <Rafael.Vanoni at sun.com>: > Li, Aubrey wrote: >> >> event window is bad. >> >> 1) nlines: in the patch, nlines = maxy-13. >> This is wrong, it should depend on max(ncstates, npstates). >> >> 2) begin y: in the patch, begin_y = win_pos++. >> nlines(wakeup) = 1, begin_y(wakeup) = win_pos++, >> then begin_y(acpi_power) = win_pos++ has no problem. >> But the patch set nlines(acpi_power) = 2, so begin_y of the next >> subwindow >> should be begin_y(acpi_power) + 2, not just win_pos++. >> >> Is that correct? >> >> 3) please consider to give one blank line between event window and >> suggestion window. > > Cool, good points. > I cleaned it up and re-wrote it so it's human readable now. Let me know if > you think I overdid it :) > When you were drawing cstate window, I guess you were still confused with what is nlines and what is end_y.
int cstate_lines = max(ncstates, npstates) + LINES_TITLE_SW + + BEGINY_CSTAT_SW + BLANK_LINE; + + cstate_window = subwin(stdscr, cstate_lines, maxx, BEGINY_CSTAT_SW, 0); here, nline(cstate) = max(ncstates, npstates) + c-state-title + [BLANK_LINE]; I failed to understand why need to add LINES_TITLE_SW and BEGINY_CSTAT_SW. And, It's good to see there is one blank line between suggestion and event window. But the blank line between cstate and wakeup window is disappear. Thanks, -Aubrey
