Rafael.Vanoni wrote: > Aubrey Li wrote: >> [snip] >> I wrote a draft for your reference. >> 1) let's define the actual lines one window uses, not including >> blank line 2) please roll back max_cstate -> ncstates, because >> ncstates is still not including C0. max_cstate is more accurate here >> 3) please don't forget to move setup_window() after data collection, >> otherwise max_cstate is not initialized. >> [snip] > > Hi Aubrey, thanks for taking the time to write the draft. > > You're right, I was trying to use a single var for everything and got > a little confused there. Here's a patch with the new changes. >
The patch looks great except C0 was still missed by this line cstate_lines = TITLE_LINE + max(max_cstate, npstates) it should be: cstate_lines = TITLE_LINE + max((max_cstate+1), npstates) Please feel free to commit after it's fixed. Thanks, -Aubrey
