[
https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608252#action_12608252
]
David Reiss commented on THRIFT-40:
-----------------------------------
This is great work. I'd like to request a few changes, though.
1/ Please use configure.ac as the authoritative source for the latest release.
(It is the second param ot AC_INIT.)
2/ Please use $(topsrcdir) instead of ../.. in Makefile.am. (I'm not 100% sure
if it will work in this context, but if it doesn't then we need to find another
solution.)
3/ please use argv[i] in "you have a right" check for consistency with the
error check below.
4/ Please put a comment explaining why version.h is declare phony even though
it is not.
My intuition is that the version might not always be updated properly on an svn
up. It would be good if we could figure out how to solve this, but for now I
am fine with the current rebuild strategy.
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
> Attachments:
> 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch,
> thrift-40.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
