[
https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608595#action_12608595
]
David Reiss commented on THRIFT-40:
-----------------------------------
Yeah, I just meant to replace VERSION with the version in configure.ac. I
think it is simpler to have configure.ac be the authoritative source for this
(like every other autoconf-based project), rather than creating an extra file
for it. I don't think we should try to include the full svn/git version
information in configure.ac. It is only used for make dist, afaik, which we
will only be using on releases.
I have another solution for main.cc. It never recompiles the compiler
unnecessarily, but it doesn't update the version if you run "make thrift"
instead of "make". I think this is a good compromise. What do you think?
Incremental changes:
http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/version;hb=HEAD
Full diff:
http://gitweb.thrift-rpc.org/?p=thrift.git;a=treediff;h=5809c82;hp=c1339c0
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
> Attachments:
> 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch,
> 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch,
> thrift-40.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
