[ 
https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608600#action_12608600
 ] 

Kevin Ballard commented on THRIFT-40:
-------------------------------------

As I mentioned earlier, both macports and git (which are autoconf-based 
projects) have configure.ac pull in the version from an external source. I 
don't see the point in making configure.ac embed the raw string and having 
something else have to parse that file when it really is simpler to just have a 
VERSION file.

In any case, your patch would be acceptable. I should point out that if the 
generated version.h file is identical to the old one, you don't bother rm'ing 
the tempfile.

> Make the compiler respond to --version
> --------------------------------------
>
>                 Key: THRIFT-40
>                 URL: https://issues.apache.org/jira/browse/THRIFT-40
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Compiler (General)
>            Reporter: Bryan Duxbury
>         Attachments: 
> 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, 
> 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, 
> thrift-40.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to