On Fri, Aug 13, 2010 at 8:18 AM, David Reiss <dre...@facebook.com> wrote:
> +1 > > There are a few "._BLAH" files in there that would be nice to remove, but > not critical. > Do you feel like opening a ticket for this cleanup? We can tackle it in the next release. > > As an aside... > > Does anyone use configure and make to build the ruby stuff? If not, can we > just > delete Ruby support from the configure script? It's gotten in my way > several > times when working on the build, and I don't know enough about Ruby to fix > it. > I personally would be OK with this change, since I've never once used it. I agree that there's an argument to be made for consistency, though. I'd like to hear some more opinions. > > --David > > On 08/13/2010 07:30 AM, Bryan Duxbury wrote: > > I certainly do intend to maintain the rubygem. I'm not sure that I have > the > > necessary credentials to publish the gem to rubyforge, though. You can > build > > the gem by doing "cd lib/rb && rake package". > > > > On Fri, Aug 13, 2010 at 4:36 AM, Rajesh Malepati <chitt...@gmail.com> > wrote: > > > >> +1 > >> > >> My ruby client/server tests pass. I had to regenerate the ruby classes > >> though. The 0.2 generated ones are incompatible with 0.4. > >> > >> One small question. Evan Weaver used to release ruby library as a gem. > >> That didn't happen for 0.3. > >> > >> See http://rubygems.org/gems/thrift and > http://github.com/fauna/thrift-rb > >> I also see Kevin Ballard, Kevin Clark and Mark Slee as authors on the > >> rubygems.org page. Is there any interest in maintaining the gem > >> version? > >> > >> On Fri, Aug 13, 2010 at 12:27 PM, Michael Lum <michael....@openx.org> > >> wrote: > >>> Works fine on CentOS 5.5. On Snow Leopard, make check was returning > >> this: > >>> > >>> libtool: link: g++ -g -O2 -o .libs/UnitTests UnitTests-UnitTestMain.o > >>> UnitTests-TMemoryBufferTest.o UnitTests-TBufferBaseTest.o > >> -Wl,-bind_at_load > >>> ./.libs/libtestgencpp.a > >>> /Users/mlum/temp/0.4.x/thrift-0.4.0/lib/cpp/.libs/libthrift.dylib > >>> -lboost_unit_test_framework -lpthread > >>> ld: library not found for -lboost_unit_test_framework > >>> collect2: ld returned 1 exit status > >>> make[2]: *** [UnitTests] Error 1 > >>> make[1]: *** [check-am] Error 2 > >>> make: *** [check-recursive] Error 1 > >>> > >>> I have boost-1.42.0 installed using MacPorts in /opt/local. Changing > the > >>> Makefile.am to add $(BOOST_LDFLAGS) to UnitTests_LDADD causes this test > >> to > >>> pass. All other tests passed. > >>> > >>> --- test/Makefile.am.orig 2010-08-12 23:29:21.000000000 -0700 > >>> +++ test/Makefile.am 2010-08-12 23:34:28.000000000 -0700 > >>> @@ -68,7 +68,7 @@ > >>> TMemoryBufferTest.cpp \ > >>> TBufferBaseTest.cpp > >>> > >>> -UnitTests_LDADD = libtestgencpp.la -lboost_unit_test_framework > >>> +UnitTests_LDADD = libtestgencpp.la $(BOOST_LDFLAGS) > >>> -lboost_unit_test_framework > >>> > >>> # > >>> # TFDTransportTest > >>> > >>> Otherwise, +1. > >>> > >>> On 8/12/2010 9:40 PM, Bryan Duxbury wrote: > >>>> > >>>> Hi all, > >>>> > >>>> As discussed, in all the time it took for us to finally release Thrift > >>>> 0.3, > >>>> we've accumulated enough changes for Thrift 0.4! > >>>> > >>>> I propose we accept > >>>> > >>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz> > <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz> > >> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as > >>>> the official Thrift 0.4.0 release. > >>>> > >>>> I created this tarball by checking out URL: > >>>> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and > >>>> running > >>>> "./bootstrap.sh&& ./configure&& make dist". > >>>> > >>>> The GPG signature for this tarball can be found at > >>>> > >>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc> > <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc> > >> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>. > >>>> It has an MD5 signature of c272591c1b3560fdef86104e2be214dc. > >>>> > >>>> Please download, verify the signatures, untar, and install and test > the > >>>> libraries you are familiar with. We need your +1 votes to make the > >>>> release! > >>>> If you encounter any problems, please let me know immediately. This > vote > >>>> will close 72 hours from now. > >>>> > >>>> This release consists of 45 tickets that cover many bugs and > performance > >>>> improvements. Please refer to the CHANGES file for the full list. > >>>> > >>>> -Bryan > >>>> > >>> > >> > > >
