On Fri, Aug 13, 2010 at 09:15:50AM -0700, Bryan Duxbury wrote:
> On Fri, Aug 13, 2010 at 8:18 AM, David Reiss <dre...@facebook.com> wrote:
> > As an aside...
> >
> > Does anyone use configure and make to build the ruby stuff?  If not, can we
> > just
> > delete Ruby support from the configure script?  It's gotten in my way
> > several
> > times when working on the build, and I don't know enough about Ruby to fix
> > it.
> >
> 
> I personally would be OK with this change, since I've never once used it. I
> agree that there's an argument to be made for consistency, though. I'd like
> to hear some more opinions.

The main issue I've had with the ruby stuff is it doesn't respect DESTDIR
so is pretty much impossible to package using standard rpm/deb tools, so
I usually disable it.  Thus I'd be fine with removing it unless someone
more up on the ruby tech could get DESTDIR to work, then I'd be okay with
it staying.

You can easily reproduce the problem if someone is interested in attempting
a fix.

1. download an instant build
2. % ./configure 
3. % make
4. % mkdir tmp
5. % make DESTDIR=`pwd`/tmp install

You'll get this

gmake[3]: Entering directory `/home/molinaro/thrift-instant-r985088/lib/rb'
gmake  install-exec-hook
gmake[4]: Entering directory `/home/molinaro/thrift-instant-r985088/lib/rb'
/usr/bin/ruby setup.rb install
rm -f InstalledFiles
---> lib
mkdir -p /usr/lib/ruby/site_ruby/1.8
install thrift.rb /usr/lib/ruby/site_ruby/1.8/
setup.rb:633:in `initialize': Permission denied - 
/usr/lib/ruby/site_ruby/1.8/thrift.rb (Errno::EACCES)
        from setup.rb:633:in `open'
        from setup.rb:633:in `install'
        from setup.rb:1377:in `install_files'
        from setup.rb:1376:in `each'
        from setup.rb:1376:in `install_files'
        from setup.rb:1350:in `install_dir_lib'
        from setup.rb:1532:in `__send__'
        from setup.rb:1532:in `traverse'
         ... 7 levels...
        from setup.rb:826:in `__send__'
        from setup.rb:826:in `invoke'
        from setup.rb:773:in `invoke'
        from setup.rb:1578
gmake[4]: *** [install-exec-hook] Error 1
gmake[4]: Leaving directory `/home/molinaro/thrift-instant-r985088/lib/rb'
gmake[3]: *** [install-exec-am] Error 2
gmake[3]: Leaving directory `/home/molinaro/thrift-instant-r985088/lib/rb'
gmake[2]: *** [install-am] Error 2
gmake[2]: Leaving directory `/home/molinaro/thrift-instant-r985088/lib/rb'
gmake[1]: *** [install-recursive] Error 1

It's probably an easy fix for someone familiar with ruby/rake, and would
probably take care of most of the problem.

-Anthony

-- 
------------------------------------------------------------------------
Anthony Molinaro                           <antho...@alumni.caltech.edu>

Reply via email to