It seems that the -fg was implemented differently than expected:
diff between old and new
-system("$vncUserDir/xstartup >> " .
"edString($desktopLog) . " 2>&1 &");
+if ($opt{'-fg'}) {
+ system("$vncUserDir/xstartup >> " .
"edString($desktopLog) . " 2>&1");
+ if (kill 0, `cat $pidFile`) {
+ $opt{'-kill'} = ':'.$displayNumber;
+ &Kill();
+ }
+} else {
+ system("($vncUserDir/xstartup; $0 -kill :$displayNumber)
>> " . "edString($desktopLog) . " 2>&1 &");
+}
Seems like a wrongly patched file, as both strings now contain a
kill. The attached patch should fix it.
The new behaviour should only be invoked when adding the -fg switch.
If omitted, nothing should be different.
Sebastiaan
On 03/11/2011 03:25 PM, Robert Goley wrote:
Just to throw my 2 cents in as well... I would prefer this
behavior be reverted as well. I know it will end up causing us
problems if for no other reason than window managers crash and we
don't want everything else in our session to be taken down with
them....
Robert
On 03/11/2011 06:57 AM, Adam Tkac wrote:
On Thu, Mar 10, 2011 at 07:07:17AM -0600, DRC wrote:
http://www.virtualgl.org/DeveloperInfo/TigerVNCPreReleases
-- Windows TLS refresh issue fixed (I hope)
-- New vncserver -fg switch for running TigerVNC in grid environments
-- vncserver now automatically kills Xvnc whenever the window manager
running in the VNC session is exited
I'm quite reserved about this behavior, I would rather not kill the
Xvnc when WM exits.
Default .vnc/xstartup (generated by vncserver) file has following
lines:
...
xsetroot -solid grey
xterm -geometry 80x24+10+10 -ls -title "$VNCDESKTOP Desktop" &
twm &
So WM is actually successfully started but patched vncserver kills Xvnc
immediately.
In my opinion vast majority of VNC users start WM on the background
(with the "&" character in the end of the script) and this change will
break all existing configurations.
In my opinion this change should be reverted.
Regards, Adam
-- vncserver will no longer prompt user to create a VNC password if VNC
auth is not used
-- TLS support incorporated into Windows Visual C++ 32-bit build, so it
isn't necessary to use a separate installer for TLS support (note: Win64
support for TLS is still not there, because GnuTLS does not yet work
cleanly with the LLP64 data model.)
Enjoy!
------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
--
Robert Goley
FOSS
Implementation Specialist
Toll Free: (800) 338-4984
Local: (770) 479-7933
Fax: (770) 479-4076
www.openrda.com
America's only Free & Open Source
fund accounting software company.
------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
|
--- vncserver.bad 2011-03-10 10:26:14.032313875 +0100
+++ /usr/bin/vncserver 2011-03-11 15:40:49.000000000 +0100
@@ -344,7 +344,7 @@
&Kill();
}
} else {
- system("($vncUserDir/xstartup; $0 -kill :$displayNumber) >> " . "edString($desktopLog) . " 2>&1 &");
+ system("$vncUserDir/xstartup >> " . "edString($desktopLog) . " 2>&1 &");
}
exit;
------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
