Hello, Ravi. I am gonna comment here on the whole set of patches :).
- Title: please use "bitbake: toaster: " as the start of all subject lines. This helps with merging upstream, and makes some porting scripts between oe-core and bitbake trees work :) - Title needs to be a bit more descriptive. Ie. instead of "Base table enhancements" - "Base table fix sorting header link and icon" - Please squash all "All Tasks" patches in a single one, since functionally it's all about a single thing - getting the task table to work. The code itself looks good to me. Cheers, Alex On Wed, Jan 15, 2014 at 8:02 PM, Ravi Chintakunta < [email protected]> wrote: > Hi Alex, > > I have pushed a commit to ravi/all-tasks-feature to set the page title if > viewName is set in the context. > > > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/all-tasks-feature&id=ad93ca464bf50fc798a507532feaeae02f9ba653 > > Thanks, > Ravi > -- Alex Damian Yocto Project SSG / OTC
_______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
