On 15/01/2014 20:02, "Ravi Chintakunta" <[email protected]> wrote:
>Hi Alex, > >I have pushed a commit to ravi/all-tasks-feature to set the page title if >viewName is set in the context. > >http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/all- >tasks-feature&id=ad93ca464bf50fc798a507532feaeae02f9ba653 Thanks, Ravi. I have a few front-end comments, if that's ok: * The icon indicating the applied sorting direction should be icon-caret-down and icon-caret-up, instead of icon-circle-arrow-down and icon-circle-arrow-up * Some of the table headings have inline styles. Those were there in the prototype, but we should probably not use them in the real thing. You can set the right font weight in default.css adding th > a, th > span { font-weight: normal; } * The table heading with the applied sorting criteria (Order) should be bold and dark grey. In the prototype I apply a class="sorted" to it, with the class defined in default.css like this .sorted { color: #333333; font-weight: bold; } .sorted:hover { color: #000000; text-decoration: underline; } * Headings that are not sortable (Recipe version) should have the .muted class applied * In the tasks table, all headings should be sortable, except for 'Recipe version¹ * In the table itself, the following should not show: ** For covered tasks, the covering task (it should say just Covered and not Covered by gnu-config-native.do_build). Most tasks will be covered by more than one task, and showing them all in the table will make it hard to read. ** Time when 0. When time is 0, the cell should be empty ** CPU usage and Disk I/O when None. If they are None, the cell should be empty ** Cache attempt when Not applicable. If it is Not applicable, the cell should be empty Cheers Belén > >Thanks, >Ravi >_______________________________________________ >toaster mailing list >[email protected] >https://lists.yoctoproject.org/listinfo/toaster _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
