Hi Alex, Comments inline.
From: Damian, Alexandru [mailto:[email protected]] Sent: Thursday, January 16, 2014 12:03 PM To: Ravi Chintakunta Cc: [email protected] Subject: Re: git push - set page title Hello, Ravi. I am gonna comment here on the whole set of patches :). - Title: please use "bitbake: toaster: " as the start of all subject lines. This helps with merging upstream, and makes some porting scripts between oe-core and bitbake trees work :) I cleaned up my previous commits and added bitbake: toaster: - Title needs to be a bit more descriptive. Ie. instead of "Base table enhancements" - "Base table fix sorting header link and icon" Handled in my latest commit. - Please squash all "All Tasks" patches in a single one, since functionally it's all about a single thing - getting the task table to work. Done. The code itself looks good to me. Thanks, Ravi
_______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
