Thanks for all the work, Ravi. Some comments inline. Cheers
Belén On 18/01/2014 16:45, "Ravi Chintakunta" <[email protected]> wrote: >Hi Belen, > >Comments inline. > >> >> Thanks, Ravi. I have a few front-end comments, if that's ok: > >Not a problem, I appreciate your comments. > >> >> * The icon indicating the applied sorting direction should be >> icon-caret-down and icon-caret-up, instead of icon-circle-arrow-down >> and >> icon-circle-arrow-up > >Fixed. > >> >> * Some of the table headings have inline styles. Those were there in >> the >> prototype, but we should probably not use them in the real thing. You >> can >> set the right font weight in default.css adding >> >> th > a, th > span { font-weight: normal; } > >Fixed and added style to default.css > >> >> * The table heading with the applied sorting criteria (Order) should >> be >> bold and dark grey. In the prototype I apply a class="sorted" to it, >> with >> the class defined in default.css like this >> >> .sorted { color: #333333; font-weight: bold; } >> .sorted:hover { color: #000000; text-decoration: underline; } > >Done. With this I do not see distinctive difference between sortable >header and the actively sorted header. It looks like in default.css the .sorted class is missing the font-weight:bold declaration. Also, in line 178, you are setting the color of th > a, th > span to #333333. This is overridding the default anchor colour (#0088CC). We just need to delete the color:#333333 declaration. Those changes should set the styles right. >> >> * Headings that are not sortable (Recipe version) should have the >> .muted >> class applied >> >> * In the tasks table, all headings should be sortable, except for >> 'Recipe >> version¹ From what I can see, there are several headings that are currently not sortable (recipe, recipe version, time, cpu, disk I/o and log). All columns, except recipe version, should be sortable. >> >> * In the table itself, the following should not show: >> >> ** For covered tasks, the covering task (it should say just Covered >> and >> not Covered by gnu-config-native.do_build). Most tasks will be covered >> by >> more than one task, and showing them all in the table will make it >> hard >> to read. >> >> ** Time when 0. When time is 0, the cell should be empty >> >> ** CPU usage and Disk I/O when None. If they are None, the cell should >> be >> empty >> >> ** Cache attempt when Not applicable. If it is Not applicable, the >> cell >> should be empty >> > >Fixed all the above. > >Thanks, >Ravi _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
