On Wed, Oct 04, 2006 at 05:38:33PM -0400, James Carlson wrote: > Dan Price writes: > > http://cr.grommit.com/~dp/webrev.3/ > > By the way, I ran this page through validator.w3.org/check. It's > clean. Very nice. :-) > > Unfortunately, my eyes started glazing over somewhere in the middle of > webrev.sh, so I don't think this counts as the thorough review you > wanted. :-< > > scripts/wx.sh > > 1137: nit: suggest "$@" instead of $* here.
I agree. > 4791-4796,5243: this doesn't feel right. Why wouldn't this be just: > > webrev) wx_webrev "$@" > shift $#;; I think he did that because wx pokes around in the args at 4799 and after that does a series of checks to make sure things are properly initialized. args, after wx sets it, are not suitable for webrev but the init checks should be done. No doubt wx could be refactored (in many places) but for now I think Dan's logic is okay. However I see something that Dan did not change but should and that is: 4785 orig_args="$*" should be: 4785 orig_args="$@" -- Will Fiveash Sun Microsystems Office x64079/512-401-1079 Austin, TX, 78727 (TZ=CST6CDT), USA Internal Solaris Kerberos/GSS/SASL website: http://kerberos.sfbay Info about krb-diag: http://kerberos.sfbay/krb-tool-info.html _______________________________________________ tools-discuss mailing list tools-discuss@opensolaris.org
