Quoth Dan Price on Sat, Oct 14, 2006 at 02:15:08AM -0700: > On Fri 06 Oct 2006 at 04:14PM, David Bustos wrote: > > tools/scripts/webrev.sh > > HTML= & FRAMEHTML=: These seem mostly the same. Can we combine them > > with printf(1) or such? > > These are two hard coded strings... I don't see the value in replacing > them with code...
I think the value is reduced possibility that someone will change both of them in inconsistent ways. > > strip_unchanged(): > > - Can we put this closer to sdiff_to_html(), which is the only place > > it's used? > > > > - Wouldn't it be a lot easier to take the diff -u output and blank > > the + lines for the left side and blank the - lines for the right > > side? I suppose you'd have to do some computation for changed > > lines. > > Possibly--- again, I left this code alone. Can you please at least move it? > > 2279: This seems like it's missing something. > > I'm not understanding this clue. What is missing? Nevermind. David _______________________________________________ tools-discuss mailing list tools-discuss@opensolaris.org
