On Wed 04 Oct 2006 at 05:38PM, James Carlson wrote:
> scripts/wx.sh
>
> 1137: nit: suggest "$@" instead of $* here.
>
> 4791-4796,5243: this doesn't feel right. Why wouldn't this be just:
>
> webrev) wx_webrev "$@"
> shift $#;;
Fixed as per previous discussion.
> 205: this doesn't seem to do anything in Firefox; but maybe I'm
> missing something.
It does in mine--- it should invoke a print dialog. You should
also be able to select "print preview" in the File menu to see how
this will print.
> scripts/webrev.1
>
> 52-53: why would this be needed? Doesn't "wx webrev" do the same?
I know there was a reason I stuck -W in there, but maybe it isn't
needed anymore. I'll go look at it again; if it's vestigal, I'll nuke
it.
> scripts/webrev.sh
>
> 539: wouldn't "perl -e" work?
Perhaps-- is there any particular advantage?
> 581: seems to leave temp files lying around.
The script has a convention that $$.* is made by it. It will nuke
all /tmp/$$.* files:
trap "rm -f /tmp/$$.* ; exit" 0 1 2 3 15
Thanks for taking a look.
-dp
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org
