Quoth Dan Price on Wed, Oct 11, 2006 at 04:59:33PM -0700: > On Fri 06 Oct 2006 at 04:14PM, David Bustos wrote: > > Quoth Dan Price on Sun, Oct 01, 2006 at 09:52:59PM -0700: > > > http://cr.grommit.com/~dp/webrev.3/ ... > > tools/scripts/webrev.1 ... > > 294: I wonder if this should be CODEMGR_PARENT-relative, rather than > > hardcoded to /ws/onnv-gate. > > Then you'd break people working on children of project gates I think. > Let's leave it as is for now, it would be easy to change if we get > complaints. I believe I also look for wdiff in $PATH, which should > help.
Ok. > > tools/scripts/wdiff.pl > > 77: Should some of this be in a style file shared with the other HTML > > files? > > Maybe-- but it would make these tools less self contained, which > seems like a nice feature currently. The cost of keeping them > in sync is pretty small. Ok. > > old 296: You're no longer setting the width of the hb-elided elements. > > That was the whole point of setting widths: to tell whether the code > > is wider than 80 columns. > > I'll go back and revisit. When I played with this it was causing > me a lot of grief, because all the cmdbox tables were nested on the > page, due to this bug: > > 181 -<table> > 247 +</table> > > But maybe I misunderstood the intent. Is the desired behavior for > the elision box to never be wider than 80 columns? I think it's best for both the hide bar and the box around unchanged code to be 80 columns, so reviewers can tell when lines are too long. David _______________________________________________ tools-discuss mailing list tools-discuss@opensolaris.org
