On Wed 11 Oct 2006 at 01:03PM, Will Fiveash wrote:
> On Wed, Oct 11, 2006 at 08:49:46AM -0700, Stacey Marshall wrote:
> > This is looking real good :-)
> > I like the new 'raw' file, most useful :-)
> > I wonder if 'new' and 'old' should simply be the raw files???
>
> I agree with Darren that line numbers are useful. I like having both
> new and raw.
It's more than just that: if we only showed the "raw" file, then your
browser might attempt to render it-- for example if it was an XML
file. The "new" and "old" versions are "html escaped."
> > Anyhow, I have looked at webrev.sh:
> ...
> > line 1597: if the wx/active file is not specified and not
> > auto-detected should we not exit?
>
> Speaking of wx, one thing which would be nice is webrev supporting the
> WXDIR environment variable as wx does. This allows one to point wx to a
> non-default dir. in which its state files are kept. webrev should use
> this to find wx files that it looks for. Note that this is not among
> the RFE's that Dan is working on but if you think you'd do it I'd open
> the RFE.
I'd rather get this done and halt the feature creep. You should file
the RFE for a future round of enhancements.
-dp
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org
