Dan Price wrote:
On Wed 11 Oct 2006 at 08:49AM, Stacey Marshall wrote:
[...]
line 1813 & 2162: The use of 'cat' would not be necessary if the input was
read directly from the file using stdin redirection
"while read line; do ... done < filename"
However, that said the, this way the filename is nearer
the actual use of the file!  So happy to leave this ;-)

My thought exactly...
:-)
line 1837, 1844, 1851 (and possibly others): the use of "==" is
preferred in ksh test "[[ ]]".

Really?  I couldn't find anything in the test or ksh man page
about this.  How do I learn these preferences?
I guess our version of ksh pre-dates this preference. I read "= string equality (obsolete)" in "The New KornShell" by Morris Bolsky and David Korn. ISBN 0-13-182700-6.
line 1346: Specific use of /bin/rm here, but not else where!

Fixed.

Thanks for your review...
Your welcome.
        -dp

Stace

--

Stacey Marshall. Solaris Revenue Product Engineering, EMEA -----------------------------------------------------------------------
http://blogs.sun.com/ace


Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org

Reply via email to