On Thu, Sep 17, 2009 at 3:54 PM, Richard Lowe <richl...@richlowe.net> wrote: > Cyril Plisko <cyril.pli...@mountall.com> writes: > >> Hi ! >> >> I've recently spent some time adding git support to webrev and it >> works reasonably well [1]. >> I am interested in committing these changes upstream. I am also >> willing to maintain git support in the future if the changes would be >> accepted. >> Would there be any objections ? If not, what would be the best way to >> proceed ? Is it enough to file an RFE or ARC review would be required ? > > I'd really like us to be cautious about piling in tools support for > whichever SCM people happen to like best at any given time, since, > eventually, that would mean "all of them".
I understand your concern, - that's why I asked whether there any objections. I personally want git support in, but if majority of the people would not like it - so be it. > Even with someone to maintain and otherwise improve it, anyone making > changes has to test with all the applicable systems, this would be the > 4th in the case of webrev (and nightly? I see it changed, but didn't > look at how.) Right, valid point. That's why I wanted to discuss it here before even filing RFE. BTW, changes to nightly are really tiny and straightforward. And yes, they are complimentary to webrev and not mandatory. > It's also worth pointing out that some of us said "No" when Roland was > attempting to expand support for Subversion, for pretty much the reasons > mentioned above: > > http://mail.opensolaris.org/pipermail/tools-discuss/2009-June/004693.html > Yes, I remember that too well. I am also impacted directly by Roland' use of subversion :) > Webrev is somewhat of a special case here, in that it's used by a much > wider number of projects (hence subversion support, for the CCD), but > I'm not sure how special. > > I'm not sure I care strongly enough to argue about it or anything, but > it's worth considering. > >> [1] http://cr.opensolaris.org/~imp/git_support.3 > > Specific comments: I will go throw these later in a separate mail. -- Regards, Cyril _______________________________________________ tools-discuss mailing list tools-discuss@opensolaris.org
