Darren J Moffat wrote:
> Plus I have a use case for webrev of git repos already :-)
Given the use of git as the upstream scm for X.Org & GNOME
communities, I'm sure I can find a use, as well as a few other
people in the Desktop & X groups.
Thanks for doing this Cyril!
As for looking at the code, I don't see anything to comment on
in the way git was used - seems reasonable enough to me, but I
didn't review that closely. (Did you really mean to put GPL
on git-active when the rest is CDDL? Since it's a seperate
program, it should be okay, just may require extra conversations
with the lawyers to integrate.)
I do see you have commented out code for detecting renames in
git-active.py - it looks like you should be able to find renamed
files by doing
git log --name-status --pretty=short -C
and looking for lines starting with R
--
-Alan Coopersmith- alan.coopersm...@sun.com
Sun Microsystems, Inc. - X Window System Engineering
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org
