On Thu, Sep 17, 2009 at 02:56:12PM +0300, Cyril Plisko wrote:
> Hi !
>
> I've recently spent some time adding git support to webrev and it
> works reasonably well [1].
> I am interested in committing these changes upstream. I am also
> willing to maintain git support in the future if the changes would be
> accepted.
> Would there be any objections ? If not, what would be the best way to
> proceed ? Is it enough to file an RFE or ARC review would be required
> ?
>
>
> [1] http://cr.opensolaris.org/~imp/git_support.3
Thanks--this is great.
It reinforces my desire that webrev be rewritten, preferably with an
architecture to support scm-specific plugins. But I can hardly ask
you to do that...
Some comments:
which_scm.1
- Please update the date on line 26
- Please remove the ident line
- Please update the copyright to 2009
which_scm.sh
- Please remove the ident line
- Please update the copyright to 2009
nightly.sh
- Please do not update nightly.sh, unless you have a specific
application where you're using it to build a git workspace.
findunref/exception_list.git
- As with nightly.sh, please don't make this change.
git-active.py
- You already satisfied my licensing concerns in a separate note
- I don't use git, so I can't really review this thoughtfully. Do you
have any git-knowledgeable folks that woulnd't mind taking a look?
webrev.sh
- Same caveat about my git knowledge
- 2056: can "git ls-tree" fail?
- 2060, 2063, 2066: WHy isn't this $olddir/$file?
- 2070-2084: similarly, it would be nice to have the new file never
listed as "$DIR/./$file" in output messages. I suspect that with
the git commands, this was done for correctness, but it would still
be useful in both cases.
- 2073: why is this needed for the new file, but not the old one?
- 2076-2077: why? (Why not use cp -p on 2075?)
- 2144-2154: can't this whole thing just be
eval build_old_new_${SCM_MODE} "$olddir" "$newdir"
or something like that?
- 2786: Why reset WDIR?
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org
