Darren J Moffat wrote: > Because this is targeted at webrev I think it is useful. Webrev is > really no longer an ON tool. Going beyond into the other tools in > SUNWonbld that are truly just for ON is a different mater. Also since > webrev already supports the other major players git is the obvious > missing one.
Sure, but if nothing else the webrev is doing more than that. It's changing nightly, and adding the findunref exception list that we specifically didn't want Roland to do for subversion, etc, etc. I'm much happier about the idea of webrev support alone than I am with the other bits present in Cyril's webrev. Alan Coopersmith <alan.coopersm...@sun.com> writes: >> Plus I have a use case for webrev of git repos already :-) > > Given the use of git as the upstream scm for X.Org & GNOME > communities, I'm sure I can find a use, as well as a few other > people in the Desktop & X groups. Indeed, I should have mentioned both those points when I replied. > Thanks for doing this Cyril! ...and that too: thanks Cyril! I'm very glad the code exists, regardless of any concerns I have. :) > As for looking at the code, I don't see anything to comment on > in the way git was used - seems reasonable enough to me, but I > didn't review that closely. (Did you really mean to put GPL > on git-active when the rest is CDDL? Since it's a seperate > program, it should be okay, just may require extra conversations > with the lawyers to integrate.) I think it must have been copied over with the copy from hg-active. I honestly don't know if derivation from hg-active means it needs to keep the GPLv2. -- Rich _______________________________________________ tools-discuss mailing list tools-discuss@opensolaris.org
