On Thu, Dec 3, 2009 at 1:06 AM, Mike Kupfer <mike.kup...@sun.com> wrote:
> The notify hook for hg.opensolaris.org uses the changeset author as the
> >From address in the email that it sends out. There is a bunch of
> complexity in that code path, since the changeset author can appear in
> various formats--in fact, it might not even be a properly-qualified
> email address.
>
> It's been suggested to me that we instead use the email address that's
> registered in Auth for the person doing the push. I like that
> suggestion for a couple reasons. One, it gets rid of a chunk of
> complexity. Two, it associates the email with the person who did the
> push, rather than the changeset author, which seems more appropriate to
> me.
Does the email of the pusher add any value to the notification mail ?
I'd think having all the notification mails coming from some
notify-dr...@hg.opensolaris.org would not be any worse. As a bonus the
level of complexity in the code would be unbeatably low :)
>
> Am I missing anything? Are there compelling reasons to continue using
> the changeset author for the From address?
>
> thanks,
> mike
>
> _______________________________________________
> tools-discuss mailing list
> tools-discuss@opensolaris.org
>
--
Regards,
Cyril
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org
