On Sat, 2009-01-10 at 00:06 +0100, Peer Sommerlund wrote: > [...] Thanks for take some time.
> You probably want to hear this from TK, but here is a quick summary as > I saw it: > > The patch series you point to contains the following changes > 1) remove quit buttons A bit long patch, but simple. > 2) transform a few minor dialogs to glade (about, backout, merge, > update) Also: - I took care about make them Gnome Human Interface Guidelines' complaint (spaces, separation, grouping, and so on). - Improve the accessibility giving navigation through the keyboard. Still are missing some relations between widgets to allow applications, such as screen readers, work better. > 3) prepare some widgets for a stand alone application Those custom widgets are not accesibles at all. > 4) add a stand alone application using glade for gui It is just the container of custom widgets. Having separated in widgets, you can plug them wherever you want. Anyway, some of them got broken with the last mercurial's change. > 5) make setup.py work outside Windows (e.g. Linux) Very simple. It is only add an if/then/else. The window's part is still the same, just indented, while it add the Linux counterpart. > 6) add submenus on Nautilus Also simple. The tricky part was fixing Nautilus to support them properly. > > As I recall it the main objection was to use glade for modelling the > GUI instead of doing everything in python. > This effectively rejects changes 2 and 4 (major rework needed) > The thread is here - > http://sourceforge.net/mailarchive/forum.php?thread_name=c50411aaaba377b34f3d.1219092640%40calcifer&forum_name=tortoisehg-develop For dialogs is not a big deal after all, but they should be reside in a different file, IMHO. My original idea was to reduce the code, to make them easier to follow/fix/spot errors. But never mind. I am not interested in follow a debate here. I discussed it technically in other place later. > > Patches 1, 5, 6 could probably be tested individually right now if > somebody fixed the minor issues and resubmitted them. As far as I remember, all of them are in sync against crew (of 3 or 4 weeks ago). I don't remember if I push them... probably yes (I have had very busy months). Regards, -- Germán Póo-Caamaño http://www.calcifer.org/ ------------------------------------------------------------------------------ Check out the new SourceForge.net Marketplace. It is the best place to buy or sell services for just about anything Open Source. http://p.sf.net/sfu/Xq1LFB _______________________________________________ Tortoisehg-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
