Hm, so that brings me to something I wanted to suggest: can we move to Bundler for the 2.0 release? It's really just a matter of merging the work I've already done<https://github.com/epall/tracks/commit/4f9ad33ab966d687cf2937dc91e1532f60fc29e4>, and it will ensure we never have conversations like this about gem versions.
As it turns out, I was running sanitize 2.0.0 which didn't work. I've updated the dependency in environment.rb to be explicit about the version of sanitize and will push to trunk shortly. Thanks for the suggestion! On Mon, Feb 28, 2011 at 11:02 PM, Reinier Balt <[email protected]> wrote: > I just ran the tests, no errors??? Could have something to do with either > your environment.rb (references onenote url’s) no being default or your > sanitize gem (I’m using 1.2.1) > > > > Reinier > > > > *Van:* Reinier Balt [mailto:[email protected]] > *Verzonden:* dinsdag 1 maart 2011 7:56 > *Aan:* 'Eric Allen' > *CC:* 'track-discuss' > *Onderwerp:* RE: [Tracks-discuss] Re: tackling last 2.0 issue > > > > Hmm, I wasn’t seeing it yesterday :-) But I did change some markup stuff at > the end of the day. I’ll check it. > > > > Reinier > > > > *Van:* Eric Allen [mailto:[email protected]] > *Verzonden:* dinsdag 1 maart 2011 7:44 > *Aan:* Reinier Balt > *CC:* track-discuss > *Onderwerp:* Re: [Tracks-discuss] Re: tackling last 2.0 issue > > > > I'm seeing a test failure with "rake test": > > > > test_format_note_link_onenote(TodosControllerTest) > [/test/functional/todos_controller_test.rb:596]: > > Expected at least 1 element matching "div#notes_todo_3 > a[href='onenote:///E:\OneNote\dir\notes.one#PAGE&section-id={FD597D3A-3793-495F-8345-23D34A00DD3B}&page-id={1C95A1C7-6408-4804-B3B5-96C28426022B}&end']", > found 0. > > <false> is not true. > > > > Are you not getting this failure? > > > > On Sun, Feb 27, 2011 at 11:59 AM, Reinier Balt <[email protected]> wrote: > > Sorry, I did not see your email until now. > > The best help now is in testing, especially the csrf stuff and session > timeouts. I think I have it fixed... I have the old tests running as well as > cucumber and selenium from cucumber. But rspec and selenium on rails I did > not work on, so if you can look at that to check if stuff is broken. > Theselenium stuff is probably more work because of all js changes. > Furthermore the new dependency editing stuff is barely tested... > > > > I think i have the last 2.0 tickets fixed, so I'd like to push a 2.0rc and > while the rc is out get more cucumber/selenium tests in. > > > > Hope you can help :-) > > > > Reinier > > Op 26 feb. 2011 om 01:19 heeft Eric Allen <[email protected]> het > volgende geschreven: > > I've been pretty absent lately, but I'd be happy to pitch in this weekend > to get 2.0rc out. How can I best help?? > > On Fri, Feb 25, 2011 at 6:22 AM, Reinier Balt <[email protected]> wrote: > > Hi all, > > It has been a while since the discussion below. I've just merged my changes > for dependencies to master. I'm closing #1092. I hope you can live with this > gui. > > I'd like to fix the remaining issues on assembla and then put out a 2.0rc. > > Have a nice weekend! > > Reinier > > > > On Wed, Sep 1, 2010 at 9:00 PM, Tim Madden <[email protected]> wrote: > > I am pretty sure my "add" button was to the right on the textfield. > Perhaps we could wrap the dependencies label, textfield and buttons with a > border to set it off... > > > > On 09/01/2010 01:27 PM, Luis Villa wrote: > > On Wed, Sep 1, 2010 at 11:00 AM, Reinier Balt<[email protected]> wrote: > > I should probably make more explicit that I'm not a huge fan of the > > proposed > > UI, because it isn't clear that 'Add' is tied to dependencies; to the > > casual user > > We could change add into a + > > Or, we could change the autocomplete to add a todo automatically when you > select a todo from the autocomplete list. > > And then clear itself to be ready for another? That seems like a very > good idea to me, though I don't know what is involved in upgrading > jquery. > > it would be easy to confuse this 'add' with the existing 'add action.' But > > I > > admit I don't have any great proposals; the obvious one (moving 'add' next > > to > > the text entry field, instead of under) would make it a very narrow field. > > Hmm, I thought the add button was on the right of the text field? > > Not here (firefox 4 nightlies, mostly.) Screenshot attached. > > Luis > > _______________________________________________ > Tracks-discuss mailing list > [email protected] > http://lists.rousette.org.uk/mailman/listinfo/tracks-discuss > > > > > _______________________________________________ > Tracks-discuss mailing list > [email protected] > http://lists.rousette.org.uk/mailman/listinfo/tracks-discuss > > > > >
_______________________________________________ Tracks-discuss mailing list [email protected] http://lists.rousette.org.uk/mailman/listinfo/tracks-discuss
