On 25/10/13 11:12 +0200, Albert Cervera i Areny wrote: > 2013/10/25 <[email protected]>: > > http://codereview.tryton.org/1311002/ > > I just created this codereview which aims to implement a minimal > "Production Operation" as previously discussed [1]. The patch is not > finished but I'd like to get some feedback before resuming the > development. > > As always, comments are very welcomed.
Here are somes:
- The cost_price on WorkCenter should be only for machine as
cost_price is already managed in timesheet_cost.
I'm also wondering if the machine should not be linked to
something similar to employee like asset product (or lot).
- I think Route should be linked to Product, just like Bom's are
link to Product.
- When I see the RouteOperation are linked to WorkCenter, I think
there is something wrong. It should be linked to a kind of
WorkCenter because you don't define the employee or the machine to
use at this level but which kind of employee (capabilities) or
which kind of machine. In some way, it could be the
WorkCenterCategory (but will require to move the type on it).
- I don't think it is necessary to link Operation to the
RouteOperation. It is just like we don't link to stock moves to
the BOMInput/Output.
- Following the previous point, I will add on Operation in more of
the WorkCenter, the WorkCenterCategory (with domain contraint).
- I think the cost should be stored on the Operation, because it
could change over time on the WorkCenter definition.
- What do you think about renaming OperationLine into
OperationHistory?
- I think OperationLine has too much information by default
(especially because they could be added later by customization).
work_center sounds useless.
quantity and uom don't seem to have a clear definition.
- I'm wondering if the WorkCenter should not be stored on the
OperationLine instead of the Operation. For example, the Operation
could be done by two employees.
- I think the module should be split in two parts. One with the
“template”: WorkCenterCategory, Route, RouteOperation, Operation.
And a second with the details: WorkCenter, OperationHistory.
Because I think small production will want to show the Operations
but doesn't want to track cost of it.
--
Cédric Krier
B2CK SPRL
Rue de Rotterdam, 4
4000 Liège
Belgium
Tel: +32 472 54 46 59
Email/Jabber: [email protected]
Website: http://www.b2ck.com/
pgp0W8OakYcmO.pgp
Description: PGP signature
