2013/10/25 Cédric Krier <[email protected]>: > On 25/10/13 11:12 +0200, Albert Cervera i Areny wrote: >> 2013/10/25 <[email protected]>: >> > http://codereview.tryton.org/1311002/ >> >> I just created this codereview which aims to implement a minimal >> "Production Operation" as previously discussed [1]. The patch is not >> finished but I'd like to get some feedback before resuming the >> development. >> >> As always, comments are very welcomed. > > Here are somes: > > - The cost_price on WorkCenter should be only for machine as > cost_price is already managed in timesheet_cost. > I'm also wondering if the machine should not be linked to > something similar to employee like asset product (or lot).
You suggest to have two separate modules production_operation and production_timesheet, for example? That would sound good to me. > - I think Route should be linked to Product, just like Bom's are > link to Product. Hard to say. I think we can easily find two cases: - The route must be linked to the BOM - The route must be linked to the Product (you can use any combination of BOM and Routes) > - When I see the RouteOperation are linked to WorkCenter, I think > there is something wrong. It should be linked to a kind of > WorkCenter because you don't define the employee or the machine to > use at this level but which kind of employee (capabilities) or > which kind of machine. In some way, it could be the > WorkCenterCategory (but will require to move the type on it). In my original design I allowed to link to WorkCenter OR WorkCenterCategory. I think we can easily find both use cases: the need to hav specific workcenters and to have categories. Maybe I should stick to the original idea. > - I don't think it is necessary to link Operation to the > RouteOperation. It is just like we don't link to stock moves to > the BOMInput/Output. Linking improves traceability and allows later analysis of deviations. For example, to see that the planned value is always optimistic and thus correct it. > - Following the previous point, I will add on Operation in more of > the WorkCenter, the WorkCenterCategory (with domain contraint). Sounds good. > - I think the cost should be stored on the Operation, because it > could change over time on the WorkCenter definition. True. Maybe when Operation workflow "starts" we could store it. > - What do you think about renaming OperationLine into > OperationHistory? I agree that OperationLine is not a good name but I think History is still somewhat confusing. Maybe OperationTracking? [1] > - I think OperationLine has too much information by default > (especially because they could be added later by customization). > work_center sounds useless. > quantity and uom don't seem to have a clear definition. That's because it is not finished. My idea is that the category of work_center UOM is a constraint to the kind of UOMs allowed here. I left start and end date but I think those should go to a customization module. This way we allow core module to keep track of information without constraining it to just time. Possibly we will want to use cycles for some machines. > - I'm wondering if the WorkCenter should not be stored on the > OperationLine instead of the Operation. For example, the Operation > could be done by two employees. Tricky question. One could also add a new operation... > - I think the module should be split in two parts. One with the > “template”: WorkCenterCategory, Route, RouteOperation, Operation. > And a second with the details: WorkCenter, OperationHistory. > Because I think small production will want to show the Operations > but doesn't want to track cost of it. I don't really see a great advantage. As I understand you mean that they can just "document" the production process in the ERP but don't really keep track of what is really happening. In my experience companies already have their processes documented elsewhere and don't think they'll put it in the ERP if it is not for making real use of them. They can even have the docs as attachments of the BOM if they want. Thanks for the feedback! [1] http://www.thefreedictionary.com/track -- Albert Cervera i Areny Tel. 93 553 18 03 @albertnan www.NaN-tic.com
