jon * wrote:
>
> Ok, I finally looked at OPaL...here are some comments...
>
> #1. Gotta take the 1.2 stuff out of there. LinkedList
>
> #2. I would like to see Village used instead of straight JDBC.
>
> #3. I don't like seeing printStackTrace() in the code. These classes should
> throw all Exceptions that don't /need/ to be caught.
>
> #4. Coding conventions...I really don't like _varName.
>
> #5. You used the wrong license on the code...it should be a Turbine license.
>
> #6. PersistenceBroker: at the top, you get the dbBroker right away...this
> should be done in the constructor as it helps catch errors easier.
>
> #7. JAVADOC!
>
> #8. It appears in examples/ there is a Cource.java and a Course.java.
> <http://working-dogs.com/turbine/cvsweb/index.cgi/turbine/src/java/org/apach
> e/turbine/opl/examples/>
>
> #9. seems that lots still needs to be finished. not a bad thing...just a
> comment.
>
Perfect. Good review. 100% on the mark.
--
Kevin A Burton
Senior Software Engineer
Kendara Inc
http://www.kendara.com
Mobile: 408-910-6145
Linux - You *will* be assimilated
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Problems?: [EMAIL PROTECTED]
