----- Original Message -----
From: jon * <[EMAIL PROTECTED]>
To: Turbine <[EMAIL PROTECTED]>
Sent: Wednesday, December 15, 1999 5:20 PM
Subject: OPaL Comments
> Ok, I finally looked at OPaL...here are some comments...
>
> #1. Gotta take the 1.2 stuff out of there. LinkedList
i assume that the 1.1/1.2 issue is to allow the people using linux to use
Turbine?????
> #2. I would like to see Village used instead of straight JDBC.
OK.
> #3. I don't like seeing printStackTrace() in the code. These classes
should
> throw all Exceptions that don't /need/ to be caught.
got ya...
> #4. Coding conventions...I really don't like _varName.
.... bad habbit... will fix...
> #5. You used the wrong license on the code...it should be a Turbine
license.
??? the license i used i took from the org.apache.turbine.util.db.DBBroker
file... is this not the correct one?
> #6. PersistenceBroker: at the top, you get the dbBroker right away...this
> should be done in the constructor as it helps catch errors easier.
OK... will fix.
> #7. JAVADOC!
not as schooled in this API as i need to be, pease bear with me while i ramp
up.
> #8. It appears in examples/ there is a Cource.java and a Course.java.
>
<http://working-dogs.com/turbine/cvsweb/index.cgi/turbine/src/java/org/apach
> e/turbine/opl/examples/>
oops... for now i going to remove both... not using neither at the moment.
> #9. seems that lots still needs to be finished. not a bad thing...just a
> comment.
yes... there is still a long way to go... but its is going to be a fun ride
; )
over the next few days i'm going to be fixing all of these issues. like i
said before, i'm still pretty new to java and my OO experience comes mostly
from using PowerBuilder where unfortunately i picked up some bad habits i
need to un-learn. so where ever you see the code i write stray from java
"best practices" don't be afraid (and i know that you won't be) to let me
know ASAP.
thanks for taking the time to review the code and all of your comments.
<off topic>
how did your speaking engagement go yesterday?
</off topic>
-scott-
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Problems?: [EMAIL PROTECTED]
