> org.apache.turbine.om
> or
> org.apache.turbine.util.om
> ???
Should be in org.apache.turbine.om. Business objects are not "utility"
classes like DynamicURI or ParameterParser and should not go in util.
> I'm also suggesting moving the OM specific stuff out of the db package and
> into the OM package. OM is essentially our first pass at what will
> eventually just be OPaL based, but isn't quite there yet until OPaL is
> finished. I'm also suggesting renaming the "db" package to "dbpool" to be
> more specific.
>
> org.apache.turbine.om
> BaseObject.java
> BasePeer.java
Just to follow the pattern I would put BasePeer in
org.apache.turbine.om.peer
> org.apache.turbine.om.user
> TurbineUser.java
> User.java
> UserFactory.java
> org.apache.turbine.om.user.peer
> TurbineUserPeer.java
> VisitorRolePeer.java
I would put UserFactory in user.peer since it is not an object that models
business behavior. Otherwise +1
> org.apache.turbine.om.security
> AccessControlBuilder.java
> AccessControlList.java
> DefaultAccessControl.java
> LoginFailedException.java (Renamed from LogonFailedException.java)
> Permission.java
> PermissionSet.java
> Role.java
> RoleSet.java
> org.apache.turbine.om.security.peer
> RolePermissionPeer.java
> PermissionPeer.java
> RolePeer.java
+1
> org.apache.turbine.util.dbpool (Renamed from org.apache.turbine.util.db)
I prefer org.apache.turbine.util.db.pool
Minor difference but I like to clear up upper level dirs as much as
possible.
Also, I would keep these following classes that you proposed moving to
org.apache.turbine.om in their original package org.apache.turbine.util.db.
Reson being that stuff in om packages should model some sort of business
entity and these classes are more utility classes created to assist in
accessing the db.
> ColumnMap.java
> DatabaseMap.java
> DatabaseMapBuilder.java
> LargeSelect.java
> Query.java
> SQLExpression.java
> TableMap.java
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Problems?: [EMAIL PROTECTED]
