on 4/17/00 11:11 AM, John McNally <[EMAIL PROTECTED]> wrote:
> My orginal inclination was to say wait till after a release, since I am not
> seeing the benefit.
Here is a prime example of the benefit:
one could add a
doCheckPermissions() call before doBuild()
This is one thing that bugs me in the current system...one has to add code
like this to the top of every Screen...
SecurityCheck secCheck = new SecurityCheck(data,
"Sorry, you do not have permission to access this screen.",
data.getScreen() );
if ( !secCheck.hasPermission("add_user"))
{
return null;
}
If this was in a method instead, then that Screen could extend a Screen that
has that code in the doCheckPermission() method and you wouldn't have to
worry about duplicating the above across all Screen's or calling super().
Security would be enabled by simply extending SecureScreen. :-)
> But it should not be that difficult to retrofit current
> projects and it is probably better to deprecate it now as far as future
> users are concerned.
Bingo.
Chris, how about sending me a URL for a complete patch?
-jon
--
Scarab -
Java Servlet Based - Open Source
Bug/Issue Tracking System
<http://scarab.tigris.org/>
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Problems?: [EMAIL PROTECTED]