jorge.vargas schrieb: > On Sat, Feb 7, 2009 at 2:54 PM, Gustavo Narea <[email protected]> wrote: >> On Saturday February 7, 2009 19:50:00 Diez B. Roggisch wrote: >>>> That's what I suggested initially but some people disagreed (well, I >>>> proposed a single underscore). >>> You have a pointer to that discussion? And a single underscore might a >>> bit not-special-enough I'd say. >> It was discussed on IRC and I can't remember when exactly, sorry. >> > During the December sprint. take a look at the first instance of > allow_only in the code then look for the IRC logs for that day. > >> In this case, either one or two underscores would be fine by me. I thought >> and >> think that's better than "allow_only", but maybe it's a little late to change >> it. > > the reason to remove the require name is that it crashed with @require > and we though it was too easy to mess up (leaving the _ out) the > original issue was reported here > http://trac.turbogears.org/ticket/2063 > > the name change came later that day simply because it will be way to > easy to mess up :) as for making it a private attribute, the > compromise was to look for a really odd name someone will never have a > controller for to keep things simple to migrate. both _ and __ denote > private API which in this case it isn't,
__require__ or something simialr isn't private. It's simply special attribute names, to avoid collision with "common" names. Which is exactly what would be useful here. > and the name collision > (someone having a controller named allow_only) is a good compromise to > keep it as public api. I personally disagree, but I don't think this is important enough to create any changes so shortly before the 2.0 release. Diez --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "TurboGears Trunk" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/turbogears-trunk?hl=en -~----------~----~----~----~------~----~------~--~---
