On Wed, Apr 24, 2013 at 6:32 PM, Marek Vasut <[email protected]> wrote: > Dear Fabio Estevam, > >> On Sun, Apr 21, 2013 at 12:52 PM, Marek Vasut <[email protected]> wrote: >> > +u32 get_board_rev(void) >> > +{ >> > + struct iim_regs *iim = (struct iim_regs *)IMX_IIM_BASE; >> > + struct fuse_bank *bank = &iim->bank[0]; >> > + struct fuse_bank0_regs *fuse = >> > + (struct fuse_bank0_regs *)bank->fuse_regs; >> > + int rev = readl(&fuse->gp[6]); >> > + >> > + return (get_cpu_rev() & ~(0xF << 8)) | (rev & 0xF) << 8; >> >> Do you really need to read the fuses on m53evk? >> >> It would be better to do the same as we did for mx6: >> >> Put it into a common mx5 file: >> >> #ifdef CONFIG_REVISION_TAG >> u32 __weak get_board_rev(void) >> { >> return get_cpu_rev(); >> } >> #endif >> >> ,and then remove get_board_rev from your board file. > > We don't have that on MX5. Or do you mean I should do the work and submit this > patch afterwards ?
As a patch before this one, I'd say. No reason to add one more place to change it later. -- Otavio Salvador O.S. Systems E-mail: [email protected] http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
