Hi Neha, On Tue, 25 Apr 2023 at 01:26, Neha Malcom Francis <[email protected]> wrote: > > Hi Simon, > > On 25/04/23 01:12, Simon Glass wrote: > > Hi Neha, > > > > On Fri, 21 Apr 2023 at 06:32, Neha Malcom Francis <[email protected]> wrote: > >> > >> Support added for HS and GP boot binaries for AM65x. > >> > >> tiboot3.bin, sysfw.itb, tispl.bin and u-boot.img: For HS devices > >> tiboot3.bin_unsigned, sysfw.itb, tispl.bin_unsigned, > >> u-boot.img_unsigned: For GP devices > >> > >> Note that the bootflow followed by AM65x requires: > >> > >> tiboot3.bin: > >> * R5 SPL > >> * R5 SPL dtbs > >> sysfw.itb: > >> * sysfw > >> * board-cfg > >> * pm-cfg > >> * sec-cfg > >> * rm-cfg > >> > >> tispl.bin: > >> * ATF > >> * OPTEE > >> * A53 SPL > >> * A53 SPL dtbs > >> > >> u-boot.img: > >> * A53 U-Boot > >> * A53 U-Boot dtbs > >> > >> Signed-off-by: Neha Malcom Francis <[email protected]> > >> --- > >> arch/arm/dts/k3-am654-base-board-u-boot.dtsi | 1 + > >> .../dts/k3-am654-r5-base-board-u-boot.dtsi | 1 + > >> arch/arm/dts/k3-am65x-binman.dtsi | 551 ++++++++++++++++++ > >> board/ti/am65x/Kconfig | 2 + > >> 4 files changed, 555 insertions(+) > >> create mode 100644 arch/arm/dts/k3-am65x-binman.dtsi > > > > Reviewed-by: Simon Glass <[email protected]> > > > > Is there any way that these boards could share a .dtsi with just the > > different bits in each board's dtsi? There seems to be a lot of > > duplicate. > > > > Maybe a common k3-binman.dtsi, but the common nodes (where the filenames > of both the generated file as well as component files are all common) > would be the ti-board-config ones... and if we change that as per last > review comment to point to board/ti/<device>/config.bin then we'd have > that particular to each device as well right? > > Or do you mean to say we use #defines for all?
No I just mean having a common .dtsi as you say above. You can still override things in that if you want to, by adding a phandle and then referencing it in the board-specific file. Regards, Simon
