Hi Pavel, On 5/24/2026 7:14 PM, Pavel Golikov wrote: > Hi Jonas, > > On Sun, May 17, 2026 at 11:06:06PM +0200, Jonas Karlman wrote: >> Hi Pavel, >> >> On 5/17/2026 9:24 PM, Pavel Golikov wrote: >>> Only LPDDR4 initialization is confirmed to be working for now. >>> >>> Signed-off-by: Pavel Golikov <[email protected]> >>> --- >>> arch/arm/mach-rockchip/Kconfig | 28 +++++++++++++++++++++++++++- >>> arch/arm/mach-rockchip/rk3568/Kconfig | 16 ++++++++++++++++ >>> common/spl/Kconfig.tpl | 1 + >>> configs/generic-rk3568_defconfig | 1 + >>> 4 files changed, 45 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig >>> index 108713488af..9a6a580025e 100644 >>> --- a/arch/arm/mach-rockchip/Kconfig >>> +++ b/arch/arm/mach-rockchip/Kconfig >>> @@ -413,11 +413,15 @@ config ROCKCHIP_RK3528 >>> config ROCKCHIP_RK3568 >>> bool "Support Rockchip RK3568" >>> select ARM64 >>> + select SUPPORT_TPL >>> + select TPL_HAVE_INIT_STACK if TPL >>> + select TPL_ROCKCHIP_BACK_TO_BROM if TPL >>> select SUPPORT_SPL >>> select SPL >>> select CLK >>> select PINCTRL >>> select RAM >>> + select ROCKCHIP_SDRAM_COMMON >>> select REGMAP >>> select SYSCON >>> select BOARD_LATE_INIT >>> @@ -433,10 +437,32 @@ config ROCKCHIP_RK3568 >>> imply RNG_ROCKCHIP >>> imply ROCKCHIP_COMMON_BOARD >>> imply ROCKCHIP_COMMON_STACK_ADDR >>> - imply ROCKCHIP_EXTERNAL_TPL >> >> Not until this has been proven to work for all current supported dram >> types and configurations, please select TPL in board specific defconfigs. > > I've played with configs a littel bit, and... I'm not a Kconfig expert, but > Kconfig does not support mutually exclusive configs. So, we have to deal with > both TPL and ROCKCHIP_EXTERNAL_TPL enabled. ROCKCHIP_EXTERNAL_TPL is now takes > precedence over TPL [1]. > > One (and less affecting) option would be to enable ROCKCHIP_EXTERNAL_TPL for > all rk356x boards, and disable it for each particular board when DRAM > initialization will be considered stable for this board.
This is basically what we have now, and the path I expect we should follow. E.g. for a board that wants to use TPL with the new ddr init code should set following in defconfig (or using e.g. menuconfig): # CONFIG_ROCKCHIP_EXTERNAL_TPL is not set CONFIG_RAM_ROCKCHIP_LPDDR4=y > Another (more affecting) option is to give TPL a higher priority. This means > that external TPL would be enabled by CONFIG_TPL=n (as ROCKCHIP_EXTERNAL_TPL > would still be implied by all SoCs that support it). And we have to revisit > all > Rockchip boards configs and change ROCKCHIP_EXTERNAL_TPL=y to CONFIG_TPL=n. We cannot give TPL higher priority for binman without breaking current use cases. A few RK SoCs require building TPL or DRAM init is moved to SPL, something that make use of EXTERNAL_TPL + SPL harder than it needs. Once feature parity is reached, we have majority of board using TPL instead of EXTERNAL_TPL, or make an active push for using TPL, only then should be drop the imply ROCKCHIP_EXTERNAL_TPL. Defconfig or users can easily disable and implied Kconfig option when needed until then. > And we still want to support the case when both internal and external TPLs are > disabled, to be able to pack SPL as TPL for SoCs with huge amount of SRAM > (rk3588 with 1MB of SRAM as an example). The main boot flow for Rockchip in mainline U-Boot is to use TPL or external TPL to init DRAM, then BACK_TO_BROM to load SPL into DRAM, Please focus on such path, any other scenario can and should be dealt with in a follow-up series. > So, what is the preferred way to go? > >>> imply ROCKCHIP_OTP >>> + imply ROCKCHIP_SERIAL if !ROCKCHIP_EXTERNAL_TPL >>> imply SPL_ATF_NO_PLATFORM_PARAM if SPL_ATF >>> imply SPL_MMC_HS200_SUPPORT if SPL_MMC && MMC_HS200_SUPPORT >>> + imply TPL if !ROCKCHIP_EXTERNAL_TPL >>> + imply TPL_CLK >>> + imply TPL_DM >>> + imply TPL_LIBCOMMON_SUPPORT >>> + imply TPL_LIBGENERIC_SUPPORT >>> + imply TPL_OF_CONTROL >>> + imply TPL_OF_PLATDATA >>> + imply TPL_RAM >>> + imply TPL_ROCKCHIP_COMMON_BOARD >>> + imply TPL_SERIAL >>> + imply TPL_SYSCON >>> + imply SPL_CLK >>> + imply SPL_DM >>> + imply SPL_DRIVERS_MISC >>> + imply SPL_LIBCOMMON_SUPPORT >>> + imply SPL_LIBGENERIC_SUPPORT >>> + imply SPL_OF_CONTROL >>> + imply SPL_RAM >>> + imply SPL_REGMAP >>> + imply SPL_ROCKCHIP_COMMON_BOARD >>> + imply SPL_SERIAL >>> + imply SPL_SYSCON >> >> These should all be sorted alphanumerically, also this is adding SPL >> related implys, probably something that should be in a separate patch? > > For some reason I decided that it won't compile without selecting SPL stuff > explicitly when TPL is enabled, and blindly copied this part from rv1126 > configuration. All needed SPL configs are implied implicitly. So, would it be > better to leave SPL implies for clarity as it is done in rv1126, or drop them? I agree that all SPL options that is currently enabled by all RK3568 boards can and should be moved from board defconfig, however I have two remarks related to this change: - imply options should be ordered alphanumerically - this change should be in a separate patch, likely in a separate series Regards, Jonas > >>> help >>> The Rockchip RK3568 is a ARM-based SoC with quad-core Cortex-A55, >>> including NEON and GPU, 512K L3 cache, Mali-G52 based graphics, >>> diff --git a/arch/arm/mach-rockchip/rk3568/Kconfig >>> b/arch/arm/mach-rockchip/rk3568/Kconfig >>> index 2730220a18e..893185291d8 100644 >>> --- a/arch/arm/mach-rockchip/rk3568/Kconfig >>> +++ b/arch/arm/mach-rockchip/rk3568/Kconfig >>> @@ -61,6 +61,10 @@ config TARGET_ORANGEPI_3B_RK3566 >>> >>> endchoice >>> >>> +config SOC_SPECIFIC_OPTIONS # dummy >>> + def_bool y >>> + select HAS_CUSTOM_SYS_INIT_SP_ADDR >>> + >>> config ROCKCHIP_BOOT_MODE_REG >>> default 0xfdc20200 >>> >>> @@ -70,6 +74,18 @@ config ROCKCHIP_STIMER_BASE >>> config SYS_SOC >>> default "rk3568" >>> >>> +config TPL_LDSCRIPT >>> + default "arch/arm/mach-rockchip/u-boot-tpl-v8.lds" >>> + >>> +config TPL_STACK >>> + default 0xfdcd8000 >>> + >>> +config TPL_SYS_MALLOC_F_LEN >>> + default 0x2000 >>> + >>> +config TPL_TEXT_BASE >>> + default 0xfdcc1000 >>> + >>> source "board/rockchip/evb_rk3568/Kconfig" >>> source "board/anbernic/rgxx3_rk3566/Kconfig" >>> source "board/hardkernel/odroid_m1/Kconfig" >>> diff --git a/common/spl/Kconfig.tpl b/common/spl/Kconfig.tpl >>> index a535b61ecd3..e64316b8eb3 100644 >>> --- a/common/spl/Kconfig.tpl >>> +++ b/common/spl/Kconfig.tpl >>> @@ -127,6 +127,7 @@ config TPL_TEXT_BASE >>> config TPL_MAX_SIZE >>> hex "Maximum size (in bytes) for the TPL stage" >>> default 0x2e000 if ROCKCHIP_RK3399 >>> + default 0xe800 if ROCKCHIP_RK3568 >>> default 0x8000 if ROCKCHIP_RK3288 || ROCKCHIP_RV1126 >>> default 0x7000 if ROCKCHIP_RK322X || ROCKCHIP_RK3328 || ROCKCHIP_RK3368 >>> default 0x2800 if ROCKCHIP_PX30 >>> diff --git a/configs/generic-rk3568_defconfig >>> b/configs/generic-rk3568_defconfig >>> index a33c3af9255..4510fa94775 100644 >>> --- a/configs/generic-rk3568_defconfig >>> +++ b/configs/generic-rk3568_defconfig >>> @@ -81,3 +81,4 @@ CONFIG_USB_GADGET=y >>> CONFIG_USB_GADGET_DOWNLOAD=y >>> CONFIG_USB_FUNCTION_ROCKUSB=y >>> CONFIG_ERRNO_STR=y >>> +CONFIG_RAM_ROCKCHIP_LPDDR4=y >> >> This generic-rk3568 target is explicitly created to be generic with >> dynamic DRAM type lookup. So we cannot add explicit DRAM type support >> for this target. > > Yep. generic-rk3568 should live with BLOB forever. Made this as an example to > ease testing, as the board I am testing on is not upstream. Will drop this in > v2. > >> Regards, >> Jonas > > Regards, > Pavel > > [1] > https://source.denx.de/u-boot/u-boot/-/blob/987c93fc68a641cc735c9828872511a947e54191/arch/arm/dts/rockchip-u-boot.dtsi#L175
