Hi Pavel, On 2026-05-17T19:24:26, Pavel Golikov <[email protected]> wrote: > clk: rockchip: rk3568: Fix probe with OF_PLATDATA enabled > > Properly initialize cru address space reference when CONFIG_OF_PLATDATA > is enabled. > > Signed-off-by: Pavel Golikov <[email protected]> > > drivers/clk/rockchip/clk_rk3568.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-)
Reviewed-by: Simon Glass <[email protected]> > diff --git a/drivers/clk/rockchip/clk_rk3568.c > b/drivers/clk/rockchip/clk_rk3568.c > @@ -2906,8 +2907,14 @@ static void rk3568_clk_init(struct rk3568_clk_priv > *priv) > static int rk3568_clk_probe(struct udevice *dev) > { > struct rk3568_clk_priv *priv = dev_get_priv(dev); > +#if CONFIG_IS_ENABLED(OF_PLATDATA) > + struct rk3568_clk_plat *plat = dev_get_plat(dev); > +#endif > int ret; > > +#if CONFIG_IS_ENABLED(OF_PLATDATA) > + priv->cru = map_sysmem(plat->dtd.reg[0], plat->dtd.reg[1]); > +#endif Please fold this into a single OF_PLATDATA block matching rk3399_clk_probe() - declare plat and assign priv->cru inside one #if CONFIG_IS_ENABLED(OF_PLATDATA) guard rather than splitting them. Regards, Simon
