On 28/03/2012 10:45, Lukasz Majewski wrote: > Support for voltage (in uV) to proper register value is added. > The function tied to this callback is often PMIC dependent > and shall be defined for each device. > > Signed-off-by: Lukasz Majewski <[email protected]> > Signed-off-by: Kyungmin Park <[email protected]> > Cc: Stefano Babic <[email protected]> > ---
Hi Lukasz, > > +int pmic_vol_to_reg(struct pmic *p, int uV) You added a new entry point to pmic, but you do not use it...I have not found in your patchset why it is necessary for you. I am not sure if we require to add this to the PMIC API or hide in the pmic specific code. Other PMICs has not a a register for different voltages, but only a bit inside the same register (this is the case for the Freescale's PMICs we currently support in u-boot). Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected] ===================================================================== _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
