Hi Massimo,

Please use more neutral wording than 'useless' in subject and messages,
e.g. unneeded or unnecessary.

On 10/2/2026 6:36 PM, Massimo Pegorer wrote:
> The ROCKCHIP_COMMON_STACK_ADDR configuration option depends on
> SPL_SHARES_INIT_SP_ADDR, therefore the logical AND of the two options
> values is equal to the to value of ROCKCHIP_COMMON_STACK_ADDR.
> 
> Signed-off-by: Massimo Pegorer <[email protected]>
> ---
>  arch/arm/mach-rockchip/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
> index 5ed774159be..8e377066a43 100644
> --- a/arch/arm/mach-rockchip/Kconfig
> +++ b/arch/arm/mach-rockchip/Kconfig
> @@ -798,7 +798,7 @@ source "arch/arm/mach-rockchip/rk3588/Kconfig"
>  source "arch/arm/mach-rockchip/rv1108/Kconfig"
>  source "arch/arm/mach-rockchip/rv1126/Kconfig"
>  
> -if ROCKCHIP_COMMON_STACK_ADDR && SPL_SHARES_INIT_SP_ADDR
> +if ROCKCHIP_COMMON_STACK_ADDR

I am pretty sure this was needed with the older Kconfig, however I was
not able to reproduce such issue, also possible the 'depends on' was
missing during early work on this.

With rewording this is:

Reviewed-by: Jonas Karlman <[email protected]>

Regards,
Jonas

>  
>  config CUSTOM_SYS_INIT_SP_ADDR
>       default 0x63f00000 if SPL_TEXT_BASE = 0x60000000
> 

Reply via email to