Hi Massimo,
On 10/2/2026 6:36 PM, Massimo Pegorer wrote:
> The configuration options SPL_BSS_START_ADDR and SPL_BSS_MAX_SIZE are
> guarded by SPL_HAS_BSS_LINKER_SECTION and SPL_BSS_LIMIT options in the
> common/spl/Kconfig file where they are originally defined. Addition of
> a second config statement without 'depends on' guard causes these two
> options to be put in the configuration even when the guard is not
> selected, which is unneeded and sounds wrong.
>
> Signed-off-by: Massimo Pegorer <[email protected]>
> ---
> arch/arm/mach-rockchip/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
> index 1a2e7847c9e..5ed774159be 100644
> --- a/arch/arm/mach-rockchip/Kconfig
> +++ b/arch/arm/mach-rockchip/Kconfig
> @@ -836,11 +836,13 @@ config SPL_HAS_BSS_LINKER_SECTION
> default y if ARM64
>
> config SPL_BSS_START_ADDR
> + depends on SPL_HAS_BSS_LINKER_SECTION
This change is causing make to prompt for SPL_BSS_MAX_SIZE when building
e.g. tinker-s-rk3288_defconfig.
Maximum size in memory allocated to the SPL BSS (SPL_BSS_MAX_SIZE) [] (NEW)
> default 0x63f80000 if SPL_TEXT_BASE = 0x60000000
> default 0x43f80000 if SPL_TEXT_BASE = 0x40000000
> default 0x03f80000 if SPL_TEXT_BASE = 0x00000000
>
> config SPL_BSS_MAX_SIZE
> + depends on SPL_BSS_LIMIT
> default 0x8000 if SPL_BSS_START_ADDR = 0x63f80000
> default 0x8000 if SPL_BSS_START_ADDR = 0x43f80000
> default 0x8000 if SPL_BSS_START_ADDR = 0x03f80000
Possible adding something like following?
default 0x8000 if !SPL_HAS_BSS_LINKER_SECTION
Regards,
Jonas
