Hi Jonas, Il giorno dom 4 ott 2026 alle ore 20:40 Jonas Karlman <[email protected]> ha scritto: > > Hi Massimo, > > Please use more neutral wording than 'useless' in subject and messages, > e.g. unneeded or unnecessary.
Sure! I will reword in v2. Sorry, but my limited fluency in English makes me numb to such semantic and usage nuances. Any suggestions and lessons are really appreciated. Thanks. > > On 10/2/2026 6:36 PM, Massimo Pegorer wrote: > > The ROCKCHIP_COMMON_STACK_ADDR configuration option depends on > > SPL_SHARES_INIT_SP_ADDR, therefore the logical AND of the two options > > values is equal to the to value of ROCKCHIP_COMMON_STACK_ADDR. > > > > Signed-off-by: Massimo Pegorer <[email protected]> > > --- > > arch/arm/mach-rockchip/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig > > index 5ed774159be..8e377066a43 100644 > > --- a/arch/arm/mach-rockchip/Kconfig > > +++ b/arch/arm/mach-rockchip/Kconfig > > @@ -798,7 +798,7 @@ source "arch/arm/mach-rockchip/rk3588/Kconfig" > > source "arch/arm/mach-rockchip/rv1108/Kconfig" > > source "arch/arm/mach-rockchip/rv1126/Kconfig" > > > > -if ROCKCHIP_COMMON_STACK_ADDR && SPL_SHARES_INIT_SP_ADDR > > +if ROCKCHIP_COMMON_STACK_ADDR > > I am pretty sure this was needed with the older Kconfig, however I was > not able to reproduce such issue, also possible the 'depends on' was > missing during early work on this. It is quite common for something to be needed in a context, but later on, when the context changes, something that was needed can become unnecessary. And in many cases, it is really difficult to catch it at that moment because it does not break anything, it is just redundant. I've stumbled upon it by accident, reasoning about the linker scripts' logic and implications. Thanks for your review! Regards, Massimo > > With rewording this is: > > Reviewed-by: Jonas Karlman <[email protected]> > > Regards, > Jonas > > > > > config CUSTOM_SYS_INIT_SP_ADDR > > default 0x63f00000 if SPL_TEXT_BASE = 0x60000000 > > >
