Hi Massimo,
On 10/2/26 6:35 PM, Massimo Pegorer wrote:
The arch/arm/mach-rockchip/u-boot-tpl.lds linker script file does not
exist. Therefore, in the end, scripts/Makefile.xpl logic fallbacks on
using the arch common linker script: arch/$(ARCH)/cpu/u-boot-spl.lds.
This is also the default value of TPL_LDSCRIPT option common definition
in common/spl/Kconfig, thus dropping this RV1126 specific definition
simplifies the configuration and has no side effect on binary outputs.
The RV1126 Kconfig file with TPL_LDSCRIPT definition has been added by
ffb191e458c ("arm: rockchip: Add RV1126 arch core support") just a few
days after 957848882c8 ("rk32xx: Use standard TPL linker script") that
removed the arch/arm/mach-rockchip/u-boot-tpl.lds linker script file.
The commit date of the second follows the author date of the first: I
suppose this caused the inconsistency.
The CONFIG_[ST]PL_TEXT_BASE symbol wasn't used in
arch/arm/cpu/u-boot-spl.lds so the undef was unnecessary.
CONFIG_[ST]PL_MAX_SIZE is handled by scripts/Makefile.xpl and set as
IMAGE_MAX_SIZE in the linker scripts. I also printed the value of
LDSCRIPT in scripts/Makefile.xpl, it is the same before and after this
patch, therefore:
Fixes: ffb191e458c ("arm: rockchip: Add RV1126 arch core support")
Reviewed-by: Quentin Schulz <[email protected]>
Thanks!
Quentin
