On 16/10/2026 12:40 pm, Chen Huei Lok wrote:
From: Tien Fong Chee <[email protected]>
Return an error immediately when an invalid DDR controller type is passed
in, so that uninitialised local variables such as val and upd_val are
never used.
Signed-off-by: Tien Fong Chee <[email protected]>
Signed-off-by: Chen Huei Lok <[email protected]>
---
drivers/ddr/altera/sdram_n5x.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/ddr/altera/sdram_n5x.c b/drivers/ddr/altera/sdram_n5x.c
index 858f2e76aa9..43d654341cc 100644
--- a/drivers/ddr/altera/sdram_n5x.c
+++ b/drivers/ddr/altera/sdram_n5x.c
@@ -2450,6 +2450,9 @@ static int set_cal_res_to_umctl2(struct ddr_handoff
*handoff,
upd_val = GET_LOWB_DATA(readw((uintptr_t)(handoff->phy_base +
DMEM_MB_CDD_CHB_WW_0_1_OFFSET)));
+ } else {
+ debug("%s: Invalid DDR controller type\n", __func__);
+ return -ENXIO;
}
upd_val = max(val, upd_val);
Reviewed-by: Tien Fong Chee <[email protected]>
Best regards,
Tien Fong
